Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Feb 22, 2025


PR-Codex overview

This PR introduces a new function getMemberById for fetching team member details, modifies the AccountTeamsUI to handle image sources, and updates the project settings page to include project transfer functionality, improving team management and UI interactions.

Detailed summary

  • Added getMemberById function to fetch member details by team and member ID.
  • Updated AccountTeamsUI to use an empty string for image source fallback.
  • Refactored Page components to use getMemberById instead of getMembers.
  • Enhanced DangerSettingCard to include an optional isDisabled prop.
  • Introduced TransferProject component for transferring projects between teams.
  • Updated ProjectGeneralSettingsPage to handle project transfer logic and state.
  • Adjusted storybook stories for ProjectGeneralSettingsPage to include account roles.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Feb 22, 2025

@vercel
Copy link

vercel bot commented Feb 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2025 6:26pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 22, 2025 6:26pm
login ⬜️ Skipped (Inspect) Feb 22, 2025 6:26pm
thirdweb_playground ⬜️ Skipped (Inspect) Feb 22, 2025 6:26pm
wallet-ui ⬜️ Skipped (Inspect) Feb 22, 2025 6:26pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 22, 2025 01:15 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 22, 2025 01:15 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 22, 2025 01:15 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 22, 2025 01:15 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 22, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review February 22, 2025 01:16
@MananTank MananTank requested review from a team as code owners February 22, 2025 01:16
@codecov
Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.83%. Comparing base (514c1a8) to head (208b052).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6316   +/-   ##
=======================================
  Coverage   56.83%   56.83%           
=======================================
  Files        1168     1168           
  Lines       64793    64793           
  Branches     5258     5258           
=======================================
  Hits        36824    36824           
  Misses      27242    27242           
  Partials      727      727           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 514c1a8
packages 55.04% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 22, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 2.9 s (+35.54% 🔺) 3.8 s
thirdweb (cjs) 121.89 KB (0%) 2.5 s (0%) 5.6 s (-9.51% 🔽) 8.1 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 285 ms (-22.98% 🔽) 397 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 147 ms (-13.21% 🔽) 157 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 890 ms (+122.17% 🔺) 1.3 s

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 22, 2025

Merge activity

…6316)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the project management features by introducing team member retrieval, project transfer capabilities, and UI improvements in the `ProjectGeneralSettingsPage`. It also updates the handling of team roles and member information.

### Detailed summary
- Updated `AccountTeamsUI` to handle empty image string for avatars.
- Added `getMemberById` function to fetch team member details.
- Replaced `getMembers` with `getMemberById` in `Page` component.
- Enhanced `DangerSettingCard` to include `isDisabled` prop.
- Refactored `ProjectGeneralSettingsPage` to manage team roles and project transfers.
- Introduced `TransferProject` component for transferring projects between teams.
- Updated storybook stories to include owner and member account scenarios.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@changeset-bot
Copy link

changeset-bot bot commented Feb 22, 2025

⚠️ No Changeset found

Latest commit: 208b052

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – login February 22, 2025 18:23 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 22, 2025 18:23 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 22, 2025 18:23 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 22, 2025 18:23 Inactive
@graphite-app graphite-app bot merged commit 208b052 into main Feb 22, 2025
32 checks passed
@graphite-app graphite-app bot deleted the tool-3476 branch February 22, 2025 18:26
@vercel vercel bot temporarily deployed to Production – docs-v2 February 22, 2025 18:26 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground February 22, 2025 18:26 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui February 22, 2025 18:26 Inactive
@vercel vercel bot temporarily deployed to Production – login February 22, 2025 18:26 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants